-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[forge] indexer SuccessCriteria and new test #14851
Merged
Merged
+214
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 1h 24m total CI duration on this PR
🚨 2 jobs on the last run were significantly faster/slower than expected
|
rustielin
force-pushed
the
rustielin/forge-indexer-succ
branch
from
October 3, 2024 01:11
c86f053
to
1408da3
Compare
rustielin
changed the title
[WIP][forge] indexer SuccessCriteria
[WIP][forge] indexer SuccessCriteria and new test
Oct 3, 2024
rustielin
force-pushed
the
rustielin/forge-indexer-succ
branch
2 times, most recently
from
October 3, 2024 18:09
3f458a2
to
a6c75e2
Compare
rustielin
added
the
CICD:build-images
when this label is present github actions will start build+push rust images from the PR.
label
Oct 3, 2024
rustielin
requested review from
sitalkedia,
igor-aptos,
larry-aptos and
a team
October 3, 2024 20:52
rustielin
force-pushed
the
rustielin/forge-indexer-succ
branch
from
October 4, 2024 18:23
a6c75e2
to
5531f5d
Compare
rustielin
changed the title
[WIP][forge] indexer SuccessCriteria and new test
[forge] indexer SuccessCriteria and new test
Oct 8, 2024
sitalkedia
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - let's ensure the test is stable for few days before adding it to the forge stable suite.
rustielin
force-pushed
the
rustielin/forge-indexer-succ
branch
from
October 8, 2024 19:05
5531f5d
to
5bd6092
Compare
rustielin
force-pushed
the
rustielin/forge-indexer-succ
branch
from
October 8, 2024 19:06
5bd6092
to
f6581bd
Compare
grao1991
approved these changes
Oct 8, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:build-images
when this label is present github actions will start build+push rust images from the PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds some latency-based success criteria to Forge runs with the indexer.
Also start to add a new class of
indexer_*
test suitesHow Has This Been Tested?
CI. Also run it ad-hoc many times. Use this to calibrate some of the latency criteria: https://github.com/aptos-labs/aptos-core/actions/runs/11185219106 (see the run history on GHA)
Key Areas to Review
Metrics used for the success criteria; new test suite workloads
For the success criteria thresholds, based on some numbers from:
For example:
Type of Change
Which Components or Systems Does This Change Impact?
Checklist